-
Notifications
You must be signed in to change notification settings - Fork 170
Small dependency bump #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address errors reported by npm audit, we can bump the version for this dependency, and validate that the tests still run.
--compilers was deprecated in favor for --require. Utilize --require to have tests still run.
This tool was used for validating code coverage. Add the tool as a developer dependency.
- Fix the path to coffeescript so it runs. - Fix the path to jscoverage so it runs. - Remove outdated reference to html-doc. - Replace --compilers with --require to utilize coffeescript.
Member
Author
Without adding The problem is that |
This script actually did nothing; make build doesn't do anything. So, we'll remove it so npm does not alert us on "prepublish" being deprecated. ❯ npm i npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated. npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only. npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information. > saml2-js@2.0.7 prepublish /[...]/Clever/saml2 > make build make: Nothing to be done for `build'.
1b58b43 to
e2080a3
Compare
Member
Author
Turns out, we don't really use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to get things to a "working state."
We want to get coverage and unit tests in a good state (they run) before doing any additional changes.
This allows us to revert if necessary.