Skip to content

Update outdated dependencies #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcab merged 6 commits into from
Feb 4, 2021
Merged

Update outdated dependencies #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
511049b
dep: Bump async from ^2.5.0 to ^3.2.0
mcab Feb 3, 2021
f00ada0
dep: Bump debug from ^2.6.0 to ^4.3.0
mcab Feb 3, 2021
761788e
dep: Bump xmldom from ^0.1.0 to ^0.4.0
mcab Feb 3, 2021
57b1486
dep: Bump xmlbuilder ~2.2.0 to xmlbuilder2 ^2.4.0
mcab Feb 4, 2021
8afe878
test: Update 'contains an AuthnContext if requested'
mcab Feb 4, 2021
548d87f
chore: Bump minimum node version to >=10.x
mcab Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/saml2.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ debug = require('debug') 'saml2'
{parseString} = require 'xml2js'
url = require 'url'
util = require 'util'
xmlbuilder = require 'xmlbuilder'
xmlbuilder = require 'xmlbuilder2'
xmlcrypto = require 'xml-crypto'
xmldom = require 'xmldom'
xmlenc = require 'xml-encryption'
Expand All @@ -28,8 +28,7 @@ class SAMLError extends Error
# request.
create_authn_request = (issuer, assert_endpoint, destination, force_authn, context, nameid_format) ->
if context?
context_element = _(context.class_refs).map (class_ref) -> 'saml:AuthnContextClassRef': class_ref
context_element.push '@Comparison': context.comparison
context_element = { 'saml:AuthnContextClassRef': context.class_refs, '@Comparison': context.comparison }

id = '_' + crypto.randomBytes(21).toString('hex')
xml = xmlbuilder.create
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"license": "Apache-2.0",
"main": "index.js",
"engines": {
"node": ">=0.10.x"
"node": ">=10.x"
},
"scripts": {
"build": "coffee --bare -c -o lib-js lib",
Expand All @@ -31,13 +31,13 @@
"nyc": "^15.0.0"
},
"dependencies": {
"async": "^2.5.0",
"debug": "^2.6.0",
"async": "^3.2.0",
"debug": "^4.3.0",
"underscore": "^1.8.0",
"xml-crypto": "^0.10.0",
"xml-encryption": "^1.2.1",
"xml2js": "^0.4.0",
"xmlbuilder": "~2.2.0",
"xmldom": "^0.1.0"
"xmlbuilder2": "^2.4.0",
"xmldom": "^0.4.0"
}
}
2 changes: 1 addition & 1 deletion test/saml2.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe 'saml2', ->
authn_request = dom.getElementsByTagName('AuthnRequest')[0]

requested_authn_context = authn_request.getElementsByTagNameNS('urn:oasis:names:tc:SAML:2.0:protocol', 'RequestedAuthnContext')[0]
assert _(requested_authn_context.attributes).some (attr) -> attr.name is 'Comparison' and attr.value is 'exact'
assert _(requested_authn_context.attributes).some((attr) -> attr.name is 'Comparison' and attr.value is 'exact'), "Could not determine if specified attribute had proper value (Comparison=exact)"
assert.equal requested_authn_context.getElementsByTagNameNS('urn:oasis:names:tc:SAML:2.0:assertion', 'AuthnContextClassRef')[0].firstChild.data, 'context:class'


Expand Down