Skip to content

do not use oauth login when username + password is in connection string #93459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcmannem merged 2 commits into from
Jan 13, 2026
Merged

do not use oauth login when username + password is in connection string #93459

kcmannem merged 2 commits into from
Jan 13, 2026
+29 −6

Conversation

@kcmannem
Copy link
Contributor

@kcmannem kcmannem commented Jan 5, 2026

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Avoids oauth login in ClickHouse Client when username/password are within the connection string

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link

clickhouse-gh bot commented Jan 5, 2026 •
edited
Loading

Workflow [PR], commit [e99c7f8]

Summary: ✅

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jan 5, 2026
@GrigoryPervakov GrigoryPervakov self-assigned this Jan 6, 2026
@kcmannem kcmannem added this pull request to the merge queue Jan 13, 2026
Merged via the queue into master with commit d43f696 Jan 13, 2026
132 checks passed
@kcmannem kcmannem deleted the fix-user-pass-in-cloud-string-rebased branch January 13, 2026 15:12
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jan 13, 2026
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Jan 13, 2026
Merged
robot-ch-test-poll added a commit that referenced this pull request Jan 13, 2026
@robot-ch-test-poll
Merge pull request #94066 from ClickHouse/cherrypick/25.12/93459
160ffba 
Cherry pick #93459 to 25.12: do not use oauth login when username + password is in connection string
robot-clickhouse added a commit that referenced this pull request Jan 13, 2026
@robot-clickhouse
Backport #93459 to 25.12: do not use oauth login when username + pass…
7b83e76 
…word is in connection string
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Jan 13, 2026
Merged
This was referenced Jan 13, 2026
Closed
Closed
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 13, 2026
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 13, 2026
clickhouse-gh bot added a commit that referenced this pull request Jan 13, 2026
@clickhouse-gh
Merge pull request #94067 from ClickHouse/backport/25.12/93459
8c4a6c9 
Backport #93459 to 25.12: do not use oauth login when username + password is in connection string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrigoryPervakov GrigoryPervakov GrigoryPervakov approved these changes

Assignees

@GrigoryPervakov GrigoryPervakov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.12-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kcmannem @GrigoryPervakov @robot-ch-test-poll @robot-ch-test-poll2 @robot-clickhouse-ci-1