feat(docker): build and push both amd64 and arm64 platforms #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team 👋
First off : huge thanks for building ClickHouse and kubenetmon maintainers.
This great tooling. I’ve been using kubenetmon to measure cross-AZ traffic on my EKS clusters, and it’s promising to be incredibly useful ❤️
That said, I ran into a small issue while running it on ARM-based nodes (AWS Graviton).
The published images on GHCR were amd64-only, so
exec format errorpopped up on ARM64 nodes.Digging a bit deeper, it turned out that although PR #13 added multi-arch build support, the workflow still used
load: trueandpush: false, which meant only the amd64 image was ever pushed to GHCR (the ARM64 build never made it into the manifest).🧩 The PR in a nutshell
docker-publishjobI also kept caching between jobs via artifacts so we don’t rebuild everything twice : it’s still fast, and tests run unchanged.
✅ Result
exec format errorwhen deploying on mixed-architecture clustersmainandv*tags) will automatically publish proper multi-arch images to GHCRThanks again for maintaining kubenetmon and all the great work you’re doing in the ClickHouse ecosystem 🙌
Hopefully this PR saves a few headaches for folks running modern clusters on ARM ❤️