Skip to content

Conversation

@not-matthias
Copy link
Member

No description provided.

@not-matthias not-matthias force-pushed the cod-1483-error-building-codspeed-rust-with-clang branch 2 times, most recently from fa84134 to 0a33f8d Compare October 14, 2025 10:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fix build issues with clang and cross-compilation by centralizing lightweight logging, adding libc compatibility shims, and expanding CI to validate multiple targets.

  • Centralize printf binding in utils.zig and use it for error logging
  • Add musl compatibility header and include it in generated C
  • Replace a panic with printing + exit and add cross-compile CI job

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/utils.zig Adds a public C printf binding to avoid std.log/std.debug syscall usage.
src/c.zig Switches error logs to utils.printf; removes local printf declaration.
src/bincode.zig Replaces @Panic with utils.printf + process exit in invalidProtocol.
scripts/release.py Injects compat.h into generated C for libc portability.
includes/core.h Includes stdio.h for C compilation needs.
includes/compat.h Introduces musl LFS64 compatibility macro mappings.
.github/workflows/ci.yml Adds a cross-compile matrix using zig cc for many targets.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@not-matthias not-matthias force-pushed the cod-1483-error-building-codspeed-rust-with-clang branch from 1b460b9 to 502db41 Compare October 14, 2025 12:38
@not-matthias
Copy link
Member Author

Moved to #14

@not-matthias not-matthias deleted the cod-1483-error-building-codspeed-rust-with-clang branch October 17, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants