Skip to content

Conversation

@not-matthias
Copy link
Member

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 4, 2025

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 72 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks


ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@not-matthias not-matthias force-pushed the add-benchmarks branch 2 times, most recently from 0da4e3a to 7ab484a Compare November 4, 2025 16:05
@not-matthias not-matthias force-pushed the add-benchmarks branch 5 times, most recently from fce6155 to e16a7f8 Compare November 5, 2025 10:59
@not-matthias not-matthias requested a review from Copilot November 5, 2025 13:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a benchmarking infrastructure for Valgrind using pytest-codspeed and GitHub Actions. It enables performance tracking across different Valgrind versions and configurations.

  • Adds a Python-based benchmarking script that uses pytest-codspeed to profile Valgrind with different configurations
  • Creates GitHub Actions workflow for automated benchmarking with multiple Valgrind versions and test commands
  • Implements caching and build optimization for Valgrind in CI/CD pipelines

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
bench/bench.py Main benchmarking script with ValgrindRunner class and pytest integration for profiling Valgrind
bench/pytest.ini Pytest configuration to exclude test data directories from discovery
bench/testdata/* Git LFS pointer files for binary test data (test.py and architecture-specific binaries)
Justfile Build automation recipes for downloading, building, and installing specific Valgrind versions
.github/workflows/codspeed.yml GitHub Actions workflow for running benchmarks across matrix of commands and Valgrind versions
.github/workflows/ci.yml Updated CI workflow to skip installing package documentation for faster builds
.gitattributes Git LFS configuration for binary test data files
Comments suppressed due to low confidence (4)

bench/bench.py:11

  • Import of 'os' is not used.
import os

bench/bench.py:14

  • Import of 'sys' is not used.
import sys

bench/bench.py:15

  • Import of 'Path' is not used.
from pathlib import Path

bench/bench.py:16

  • Import of 'time' is not used.
import time

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ogltm

@not-matthias not-matthias merged commit f16dd47 into master Nov 5, 2025
72 of 75 checks passed
@not-matthias not-matthias deleted the add-benchmarks branch November 5, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants