-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add codspeed benchmarks for valgrind #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f4889c to
e4d12af
Compare
0da4e3a to
7ab484a
Compare
fce6155 to
e16a7f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a benchmarking infrastructure for Valgrind using pytest-codspeed and GitHub Actions. It enables performance tracking across different Valgrind versions and configurations.
- Adds a Python-based benchmarking script that uses pytest-codspeed to profile Valgrind with different configurations
- Creates GitHub Actions workflow for automated benchmarking with multiple Valgrind versions and test commands
- Implements caching and build optimization for Valgrind in CI/CD pipelines
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| bench/bench.py | Main benchmarking script with ValgrindRunner class and pytest integration for profiling Valgrind |
| bench/pytest.ini | Pytest configuration to exclude test data directories from discovery |
| bench/testdata/* | Git LFS pointer files for binary test data (test.py and architecture-specific binaries) |
| Justfile | Build automation recipes for downloading, building, and installing specific Valgrind versions |
| .github/workflows/codspeed.yml | GitHub Actions workflow for running benchmarks across matrix of commands and Valgrind versions |
| .github/workflows/ci.yml | Updated CI workflow to skip installing package documentation for faster builds |
| .gitattributes | Git LFS configuration for binary test data files |
Comments suppressed due to low confidence (4)
bench/bench.py:11
- Import of 'os' is not used.
import os
bench/bench.py:14
- Import of 'sys' is not used.
import sys
bench/bench.py:15
- Import of 'Path' is not used.
from pathlib import Path
bench/bench.py:16
- Import of 'time' is not used.
import time
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ogltm
e16a7f8 to
f16dd47
Compare
No description provided.