Skip to content

chore: hide exact version for codspeed valgrind to allow comparison a… #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-matthias merged 1 commit into from
Nov 6, 2025
Merged

chore: hide exact version for codspeed valgrind to allow comparison a… #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/codspeed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,9 @@ jobs:
cmd:
- testdata/take_strings-aarch64 varbinview_non_null
- echo Hello, World!
- ls bench.py
- python3 testdata/test.py
- stress-ng --cpu 1 --timeout 1s
- stress-ng --cpu 4 --timeout 1s
- stress-ng --cpu 1 --cpu-ops 10
- stress-ng --cpu 4 --cpu-ops 10
valgrind:
- "3.26.0"
- "3.25.1"
Expand Down
5 changes: 5 additions & 0 deletions bench/bench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ def pytest_generate_tests(metafunc):
),
]

# If the valgrind version is from CodSpeed, we don't want to display the exact version
# to allow comparison against older versions.
if ".codspeed" in runner.valgrind_version:
runner.valgrind_version = "valgrind.codspeed"

# Create test IDs with format: valgrind-version, command, config-name
test_ids = [
f"{runner.valgrind_version}, {runner.cmd}, {config_name}"
Expand Down
Loading