-
Notifications
You must be signed in to change notification settings - Fork 359
Add back button to project detail page #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@pratyushjha06 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
|
@pratyushjha06 Use header shareable component and pass back arrow button in leftSideChildren |
|
@pratyushjha06 Any update on reqd changes? |
@Avdhesh-Varshney Done Pls Check |
| {commentsWrapper && <CommentsWrapper />} | ||
| <Header | ||
| leftSideChildren={ | ||
| <Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of button, use A2ZIconButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pratyushjha06 Please update it accordingly
And you don't need to add custom styling in case of A2ZIconButton.
done @Avdhesh-Varshney |
|
@pratyushjha06 Do 1 more thing before commit, run this command to format the whole repo code npm run format |
@Avdhesh-Varshney I tried running npm run format but prettier is not installed. Could you please let me know which formatting command to use, or should I push the changes? |


Pull Requests Review Criteria
Caution
PRs that fail to meet these review standards will be automatically flagged and may be rejected by maintainers.
mainCloses: #1369
Describe the add-ons or changes you've made 📃
Added a back button to the project detail page to allow users to navigate back to the previous page.
Changes made:
useNavigatehook from react-router-dom andArrowBackIconfrom Material-UI iconsnavigatehook inside the Project componentnavigate(-1)to go back to previous page in browser historyLocation of changes:
client/src/modules/code/Project.tsxThis solves the issue where users had no way to exit the project page without using browser controls.
Screenshots 📷
Note to reviewers (Optional) 📄