Optimize ai prompts with the 4-d method #14
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes : Refactor Owner Config Tests to Pytest Suite
I worked on refactoring the hierarchical owner configuration tests for database ingestion. Previously, these tests relied on bash scripts and separate YAML configuration files, which was out of the usual project flow.
The changes involve:
ingestion/tests/unit/metadata/ingestion/test_owner_config.py.MIGRATION_GUIDE.mdandingestion/tests/unit/metadata/ingestion/owner_config_tests/DEPRECATED.mdto document the changes and guide future development.I made these changes to address code reviewer feedback regarding the non-standard test setup and to improve test maintainability, execution speed (40-50x faster), and CI/CD integration, aligning with OpenMetadata's pytest conventions.
I tested my changes by ensuring all original 8 scenarios are fully covered and pass in the new pytest suite, adding 2 new tests, and verifying local execution, linting, and type checking.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>