-
Notifications
You must be signed in to change notification settings - Fork 0
Implement stable glossary term links with redirection #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stable glossary term links with redirection #16
Conversation
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 27
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| showErrorToast(t('server.unexpected-error')); | ||
| } | ||
| setShowCopyUrlDropdown(false); | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dropdown Stays Open on Failed Copy
In handleCopyUrlBasedOnFqn, when entityFqn is falsy, the function returns early (line 75) without executing setShowCopyUrlDropdown(false) (line 86). This means the dropdown menu will remain open after the user clicks the menu item, providing no visual feedback that the action failed. The dropdown should be closed regardless of whether the copy operation succeeds or fails.
| showErrorToast(t('server.unexpected-error')); | ||
| } | ||
| setShowCopyUrlDropdown(false); | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dropdown Stays Open After Failed Copy
In handleCopyUrlBasedOnId, when entityId is falsy, the function returns early (line 91) without executing setShowCopyUrlDropdown(false) (line 102). This means the dropdown menu will remain open after the user clicks the menu item, providing no visual feedback that the action failed. The dropdown should be closed regardless of whether the copy operation succeeds or fails.
Describe your changes:
Fixes
I replaced the single "Copy Link" button on the Glossary Term detail page with a dropdown menu offering two options: "Copy Name-based Link (FQN)" and "Copy Permanent Link (UUID)". This change addresses the issue where the existing "Copy Link" function would copy a potentially unstable FQN-based URL. Users can now explicitly choose to copy a permanent, UUID-based link (
/glossary/{uuid}) that remains valid even if the term is renamed or moved, while still having the option to copy the more readable FQN-based link. The/glossary/{uuid}route already supports direct access to terms.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>