Skip to content

Conversation

@Code-Eat-Rabbit
Copy link
Owner

Describe your changes:

Fixes

I replaced the single "Copy Link" button on the Glossary Term detail page with a dropdown menu offering two options: "Copy Name-based Link (FQN)" and "Copy Permanent Link (UUID)". This change addresses the issue where the existing "Copy Link" function would copy a potentially unstable FQN-based URL. Users can now explicitly choose to copy a permanent, UUID-based link (/glossary/{uuid}) that remains valid even if the term is renamed or moved, while still having the option to copy the more readable FQN-based link. The /glossary/{uuid} route already supports direct access to terms.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Open in Cursor Open in Web

Co-authored-by: yourton.ma <yourton.ma@gmail.com>
@cursor
Copy link

cursor bot commented Oct 28, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@github-actions
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Co-authored-by: yourton.ma <yourton.ma@gmail.com>
@github-actions
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Co-authored-by: yourton.ma <yourton.ma@gmail.com>
@github-actions
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Co-authored-by: yourton.ma <yourton.ma@gmail.com>
@github-actions
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Co-authored-by: yourton.ma <yourton.ma@gmail.com>
@github-actions
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Co-authored-by: yourton.ma <yourton.ma@gmail.com>
@github-actions
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Co-authored-by: yourton.ma <yourton.ma@gmail.com>
@github-actions
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on November 27

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

showErrorToast(t('server.unexpected-error'));
}
setShowCopyUrlDropdown(false);
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dropdown Stays Open on Failed Copy

In handleCopyUrlBasedOnFqn, when entityFqn is falsy, the function returns early (line 75) without executing setShowCopyUrlDropdown(false) (line 86). This means the dropdown menu will remain open after the user clicks the menu item, providing no visual feedback that the action failed. The dropdown should be closed regardless of whether the copy operation succeeds or fails.

Fix in Cursor Fix in Web

showErrorToast(t('server.unexpected-error'));
}
setShowCopyUrlDropdown(false);
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dropdown Stays Open After Failed Copy

In handleCopyUrlBasedOnId, when entityId is falsy, the function returns early (line 91) without executing setShowCopyUrlDropdown(false) (line 102). This means the dropdown menu will remain open after the user clicks the menu item, providing no visual feedback that the action failed. The dropdown should be closed regardless of whether the copy operation succeeds or fails.

Fix in Cursor Fix in Web

@Code-Eat-Rabbit Code-Eat-Rabbit deleted the cursor/implement-stable-glossary-term-links-with-redirection-1524 branch October 29, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants