-
Notifications
You must be signed in to change notification settings - Fork 0
Optimize ai prompts with the 4-d method #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize ai prompts with the 4-d method #9
Conversation
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Co-authored-by: yourton.ma <yourton.ma@gmail.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Describe your changes:
Fixes
I worked on fixing the owner inheritance logic in
database_service.pybecause tables were not correctly inheriting owners from their parent schemas. Theget_owner_refmethod was attempting to retrievedatabase_schema_entityfrom the context, which was not present, leading toparent_ownerbeingNone. This resulted in tables defaulting to an incorrect owner (e.g.,finance_db.treasurytables defaulting todata-platform-teaminstead oftreasury-team).I modified the
get_owner_refmethod to correctly resolve the schema's owner by constructing the schema FQN, retrieving the database owner (for schema inheritance), and then usingget_owner_from_config()to determine the final schema owner, which is then passed asparent_ownerto the table. I tested these changes by verifying that existing inheritance tests (likeTest-05) now pass and tables under schemas with explicit owner configurations correctly inherit their owners.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>