Skip to content

Conversation

@thecoolwinter
Copy link
Contributor

Description

Fixes two small bugs:

  • When deleting a line from the line text storage, a replaced node's left subtree metadata would be replaced, instead of added to when removing that node. This caused the left subtree to be invisible in some cases, leading to broken layout.
  • Force a layout pass after editing, as was the behavior before the recent layout manager changes. Fixes an issue where editing text would not move the cursor correctly.
  • Adds a test case to the aforementioned line storage bug.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter added the bug Something isn't working label Apr 14, 2025
@thecoolwinter thecoolwinter merged commit 66e1065 into CodeEditApp:main Apr 14, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/text-disappearing branch April 14, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Crash when deleting text

1 participant