perf: add debouncing to execution methods #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent multiple executions from running concurrently using ref-based state tracking (refs are synchronous, avoiding stale closure issues) - Add 300ms cooldown after execution completion to prevent rapid double-clicks from triggering duplicate runs - Apply debouncing to execute(), executeFromNode(), and executeNodeOnly() - Update cancel() to properly reset execution state The dual-protection approach ensures both concurrent execution prevention and post-execution cooldown for a robust user experience. Co-Authored-By: Behnam & Claude Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
execute(),executeFromNode(),executeNodeOnly()cancel()to properly reset execution stateTechnical Details
The implementation uses a dual-protection approach:
isExecutingRef: A synchronous ref (not state) to check if execution is in progress. Using a ref avoids stale closure issues that can occur with useState in rapid async calls.lastExecutionTimeRef: Tracks when execution last completed, enforcing a 300ms cooldown before allowing another execution.Why refs instead of state?
React's
useStateupdates are asynchronous and can lead to stale closures when multiple rapid calls occur. By usinguseRef, we get synchronous, reliable state checking that prevents race conditions.Test plan
bun run typecheckpassesbun run lintpassesBehnam Ebrahimi