refactor: extract magic strings to centralized constants file #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create src/lib/constants.ts with all magic strings: - STORAGE_KEYS for localStorage keys - PNG_WORKFLOW_KEY for workflow metadata - NODE_PATHS for all node type paths - DRAG_DATA_TYPES for drag-and-drop data transfer - SIZE_LIMITS for file size thresholds - ERROR_MESSAGES with factory functions - MIME_TYPES and image format helpers - ASPECT_RATIOS and model name constants - Update 12 files to use centralized constants: - workflow-storage.ts - useClipboard.ts - png-metadata.ts - graph-executor.ts - WorkflowCanvas.tsx - ContextMenu.tsx - ImageHistory.tsx - SettingsDialog.tsx - ErrorBoundary.tsx - ImageHistoryContext.tsx - prompt-templates.ts - Test files - Fix lint errors in test files (unused variables, empty blocks) Co-Authored-By: Behnam & Claude Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
src/lib/constants.tswith all magic strings and repeated valuesChanges
src/lib/constants.ts- Central location for all magic stringsTest plan
bun run typecheck- passesbun run lint- passesbun run test:run- all 27 tests passBehnam Ebrahimi