Skip to content

Conversation

@bkarimii
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.
chat server Project , frontEnd has been dne as well, But I haven't uplaoded it on netlify yet because of some minor bugs.
I will update this PR As I did it.

Questions

Ask any questions you have for your reviewer.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

} else {
usersChat.push(chatData);
const latestMessages = latestTenMsg(usersChat);
res.send(latestTenMsg(usersChat));

Check failure

Code scanning / SonarCloud

Endpoints should not be vulnerable to reflected cross-site scripting (XSS) attacks

<!--SONAR_ISSUE_KEY:AY77PxTvew2BWpcU83Eu-->Change this code to not reflect user-controlled data. <p>See more on <a href="https://sonarcloud.io/project/issues?id=CodeYourFuture_Module-Node&issues=AY77PxTvew2BWpcU83Eu&open=AY77PxTvew2BWpcU83Eu&pullRequest=170">SonarCloud</a></p>

app.get("/messages/latest", (req, res) => {
const latestMsgs = latestTenMsg(usersChat);
res.status(200).send(latestMsgs);

Check failure

Code scanning / SonarCloud

Endpoints should not be vulnerable to reflected cross-site scripting (XSS) attacks

<!--SONAR_ISSUE_KEY:AY77PxTvew2BWpcU83Ev-->Change this code to not reflect user-controlled data. <p>See more on <a href="https://sonarcloud.io/project/issues?id=CodeYourFuture_Module-Node&issues=AY77PxTvew2BWpcU83Ev&open=AY77PxTvew2BWpcU83Ev&pullRequest=170">SonarCloud</a></p>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant