NW6 | Sabella Fisseha | Server Module | Mailing list #174
+151
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Author
Ara225
reviewed
May 6, 2024
| const data = require("./mailing-lists"); | ||
| const app = express(); | ||
| app.use(express.json()); | ||
| const lists = new Map(Object.entries(data)); |
There was a problem hiding this comment.
Is there any particluar reason you wanted to copy the data into a diffrent object?
| if (listsArray.length > 0) { | ||
| res.status(200).send(listsArray); | ||
| } else { | ||
| res.status(200).send({}); |
There was a problem hiding this comment.
This is not correct I'm afraid - the readme asked for an empty array not an empty object
| } else { | ||
| res.status(404).send("list not found"); | ||
| } | ||
| }); |
| const updatedList = Array.from(lists.keys()); | ||
| res.status(200).send(updatedList); | ||
| } else { | ||
| res.status(404).send("list not found"); |
There was a problem hiding this comment.
Good work - apprecate the good error checking you have here :)
| const updatedList = Array.from(lists.keys()); | ||
| res.status(201).send(updatedList); | ||
| } | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.