This repository was archived by the owner on Oct 2, 2024. It is now read-only.
London_10-Saliha_Popal/Node-Module/quote-server #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migmow
reviewed
Jul 21, 2023
| (quote) => | ||
| quote.quote.toLowerCase().includes(term.toLowerCase()) || | ||
| quote.author.toLowerCase().includes(term.toLowerCase()) || | ||
| quote === "" |
There was a problem hiding this comment.
Why are you filitering empty quotes here?
migmow
reviewed
Jul 21, 2023
server.js
Outdated
| app.get("/quotes/search", function (request, response) { | ||
| const term = request.query.term; | ||
| const searchResults = searchQuotes(term); | ||
| response.send({searchResults}); |
There was a problem hiding this comment.
I'd recommend using .json when you're sending JSON data though, because it makes it obvious to other developers that you are aiming to send JSON data back.
Would be great if you study this => https://expressjs.com/en/api.html#res.send and see the difference between .send and .json
migmow
reviewed
Jul 21, 2023
server.js
Outdated
| // ## Level 2 Challenge - allow quote _searches_! | ||
| function searchQuotes(term) { | ||
| const results = quotes.filter( | ||
| (quote) => |
There was a problem hiding this comment.
Can you think of a situation where term is undefined? can you handle it by using response.status(400) and sending a message as well?
migmow
reviewed
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?