More markdowntextblock improvements #771
Open
+229
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR improves the MarkdownTextBlock image handling by replacing fixed Width/Height sizing with a MaxWidth/MaxHeight constraint-based approach, preventing images from being stretched beyond their parent container. It also includes XAML formatting improvements for the theme options pane and updates to sample documentation.
- Changed image sizing from fixed dimensions to flexible MaxWidth/MaxHeight constraints to prevent stretching
- Simplified constraint application logic by directly using MaxWidth/MaxHeight instead of complex scaling calculations
- Reformatted XAML file with consistent indentation and attribute placement
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| MyImage.cs | Refactored image sizing logic to use MaxWidth/MaxHeight constraints instead of fixed dimensions, allowing images to scale properly within their containers |
| ThemeOptionsPane.xaml | Applied consistent code formatting with proper indentation and line breaks |
| MarkdownTextBlockCustomThemeSample.xaml.cs | Added documentation about image corner radius feature and included additional sample image |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
components/MarkdownTextBlock/samples/MarkdownTextBlockCustomThemeSample.xaml.cs
Outdated
Show resolved
Hide resolved
components/MarkdownTextBlock/samples/MarkdownTextBlockCustomThemeSample.xaml.cs
Outdated
Show resolved
Hide resolved
components/MarkdownTextBlock/samples/MarkdownTextBlockCustomThemeSample.xaml.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Tests that theme constraints should not enlarge images smaller than the constraint - Tests that precedent dimensions from markdown syntax should be respected - Tests that theme constraints properly limit larger images - Reveals current bugs where constraints are always applied regardless of context
Arlodotexe
requested changes
Jan 10, 2026
Member
There was a problem hiding this comment.
Surfaced a few regressions:
- This should be fixed in this PR before closing. Failing tests have been pushed to demonstrate the issue.
- The missing image corner radius bit should be handled in a new PR.
The remaining review comments from Copilot are either trivial and already merged or false positives.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
components/MarkdownTextBlock/samples/MarkdownTextBlockImageProviderSample.xaml.cs
Outdated
Show resolved
Hide resolved
components/MarkdownTextBlock/tests/ImageProviderConstraintTest.cs
Outdated
Show resolved
Hide resolved
components/MarkdownTextBlock/samples/MarkdownTextBlockImageProviderSample.xaml.cs
Outdated
Show resolved
Hide resolved
components/MarkdownTextBlock/samples/MarkdownTextBlockImageProviderSample.xaml.cs
Outdated
Show resolved
Hide resolved
components/MarkdownTextBlock/samples/MarkdownTextBlockImageProviderSample.xaml.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…unityToolkit/Labs-Windows into niels9001/mdtb-improvements
Arlodotexe
reviewed
Jan 12, 2026
components/MarkdownTextBlock/tests/ImageProviderConstraintTest.cs
Outdated
Show resolved
Hide resolved
11 tasks
Arlodotexe
reviewed
Jan 13, 2026
components/MarkdownTextBlock/samples/MarkdownTextBlockImageProviderSample.xaml.cs
Outdated
Show resolved
Hide resolved
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.