Skip to content

Conversation

@JamesBrooksbankIceland
Copy link

@JamesBrooksbankIceland JamesBrooksbankIceland commented Nov 7, 2025

From parent page when calling a popup, when the onnavigatedfrom event, check args if the destination is a popup page.

Unit tests implemented

Sample code applied

Description of Change

Added an extension method to OnNavigatedFrom event which checks if the destination page is a popup and if so returns true.

Linked Issues

PR Checklist

Additional information

Tested on Android.

From parent page when calling a popup, when the onnavigatedfrom event, check args if the destination is a popup page.

Unit tests implemented

Sample code applied
Copilot AI review requested due to automatic review settings November 7, 2025 14:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesBrooksbankIceland This generally looks good, thank you for it! Only one comment in the code. I have a question outside of the changes though. Could/should we also introduce an extension to know whether we are navigating from a popup? I think it could be of benefit but keen to hear from others

@TheCodeTraveler TheCodeTraveler added pending documentation This feature requires documentation waiting for feedback Waiting for a response from the author or the core team member labels Nov 10, 2025
Copilot AI review requested due to automatic review settings November 16, 2025 22:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Collaborator

@TheCodeTraveler TheCodeTraveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JamesBrooksbankIceland!

Could you please agree to the dotnet service policy allowing us to merge this PR?

This policy only requires approval from you; it is just optional to also request from the company you work for. The work you contribute to this open-source project are your own and independent from the work you contribute to your company.

@TheCodeTraveler TheCodeTraveler added approved This Proposal has been approved and is ready to be added to the Toolkit documentation approved and removed pending documentation This feature requires documentation labels Nov 18, 2025
@jamesbrooksbank
Copy link
Contributor

Unfortunately i have been told by our legal department that i cannot proceed to give permission. They have enabled to submit via my own personal account. Rather silly from my perspective but i could do with some guidance.... i have redone the work locally on my own pc in my own time, and ready to create that PR. Could you advise how to close this pr and if it will be a problem. I'm very sorry for making my first submission a mess up.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved This Proposal has been approved and is ready to be added to the Toolkit documentation approved waiting for feedback Waiting for a response from the author or the core team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants