-
Notifications
You must be signed in to change notification settings - Fork 10
T2792 Ensure child protection on children page #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 14.0-MyCompassion2.0
Are you sure you want to change the base?
T2792 Ensure child protection on children page #211
Conversation
Refactor Refactor
…e' into T2728---Make-the-weather-time-component-more-responsive
…e-component-more-responsive
Summary of ChangesHello @Shayan105, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances child protection features within the application by introducing a method to obfuscate sensitive geographical location data for children displayed on their timeline page. This change prevents the direct exposure of precise coordinates. Concurrently, it refines the naming convention for child development centers, standardizing the term 'cdc_name' and improving the resilience of how these names are retrieved and presented across relevant components. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces important child protection measures by obfuscating GPS coordinates on the child's page, and improves naming consistency by using cdc_name instead of church_name. My review focuses on improving the implementation of these changes for better performance, maintainability, and internationalization. Specifically, I've suggested optimizing a repeated function call and ensuring a fallback text is translatable, which is important for an international application.
…---Ensure-Child-Protection-on-Children-Page
…ion-on-Children-Page
…tps://github.com/CompassionCH/compassion-website into T2792---Ensure-Child-Protection-on-Children-Page
|
@ecino Your changes have been applied. |
…d coords to project model
Note
This task is linked to the PR : CompassionCH/compassion-modules#2059 and should be merged after it.
The changes in the current PR are also dependent of the changes brought by its target branch in the PR : #198
Summary
This PR solves a confidentiality issue regarding the children safety.
1 ) The Map component used to display the accurate location of the Church partner.
2) The component displayed the name of the church partner, which should not be public.
Solution
Coordinates obfuscation
The location shown in the map are now obfuscated in the following way :
The map shows the location of the closest city or the middle of the country, if these informations are not available, the map will show a random point in a radius of 100 km.
Show the CDC and not the Church name
The church name is no longer shown in the component. If available, the component will display the field child_center_original_name of the name of the project. If None of these information is available, it will just display "Compassion center".
Technical implementation