-
Notifications
You must be signed in to change notification settings - Fork 10
T2834 Improve choose for me new sponsorship workflow #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 14.0-MyCompassion2.0
Are you sure you want to change the base?
T2834 Improve choose for me new sponsorship workflow #228
Conversation
…on" when sampling a child
…sen" when a ramdom child is sampled
Summary of ChangesHello @Shayan105, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience for the 'choose for me' sponsorship workflow. Instead of navigating to a new page, users will now see a randomly selected child's profile appear instantly on the current page. This change introduces new interactive elements, allowing users to easily choose another child or view all available children, making the process more fluid and engaging. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the 'Choose for me' sponsorship workflow to display the randomly selected child on the same page instead of redirecting. The changes are generally good, introducing a helper function for animations and updating the UI state accordingly. However, I've found a critical issue in the Python backend that could cause server errors, as well as a logic flaw in the JavaScript frontend that could lead to an inconsistent UI. I've also included some suggestions for minor cleanups and best practices in the JavaScript and XML template files. Addressing these points will improve the robustness and maintainability of the new workflow.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…new-sponsorship-workflow
…new-sponsorship-workflow
…new-sponsorship-workflow
…new-sponsorship-workflow
Summary
This PR introduces a new workflow to the sponsor when trying to sponsor a new child.
User story
As a user, I want to see profile card of the randomly sampled child before checking out.
New design descirption:
The "Choose for me button" does no longer redirect to the checkout. It shows the card of the randomly sampled child and allow the user to either randomly draw a new one or to see all possible child.
Video record of the new design :
Screencast.from.16.12.2025.13.17.05.webm