T2838 create a new component for custom amount #236
Conversation
Summary of ChangesHello @SamBachmann, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience for specifying custom donation amounts. By allowing direct input into a dedicated text field, the system now automatically handles the selection of the 'custom' option, reducing user interaction steps and making the donation process more intuitive and efficient. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the donation form to improve the user experience for entering a custom donation amount. The custom amount input is now always visible, and interacting with it automatically selects the 'custom' option, saving the user a click. The changes in the JavaScript widget are well-implemented and follow Odoo's best practices. However, the XML template contains inline JavaScript handlers which are redundant and go against modern web development standards. I've suggested removing them and cleaning up the input element.
| <input | ||
| id="custom-amount" | ||
| type="text" | ||
| name="custom_amount" | ||
| t-att-placeholder="'Enter amount in %s' % product.currency_id.name" | ||
| class="form-control mt-2" | ||
| hidden="" | ||
| t-att-value="'{:g}'.format(default_custom_amount) if default_custom_amount else ''" | ||
| onclick="$(this).prev('input[type=radio]').prop('checked', true).trigger('change');" | ||
| onfocus="$(this).prev('input[type=radio]').prop('checked', true).trigger('change');" | ||
| /> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I addressed this issue
Co-authored-by: ecino <ecino@users.noreply.github.com>
In this PR I updated the flow to select a custom amount for a donation.
Now the user can directly enter the amount he wants to donate with one less click.