[T2845] - Refactore "Suggested Donation amount" should be price based and not quantity based

[SlWa99]

Refactor of Suggested Donation Amounts

Problem Description

Suggested donation amounts were previously defined as quantities multiplied by a base product price.
This made price management fragile and error-prone when the product’s sale price changed.

---

Applied Changes

Model (product.template)

• Replaced quantity-based integer fields with direct monetary fields:
  • my_compassion_donation_amount_low
  • my_compassion_donation_amount_medium
  • my_compassion_donation_amount_high

Backend

• Updated the product form view to allow direct input of donation amounts in CHF.

Frontend

• Updated QWeb templates (DonationFormComponent, DonationProductComponent) to display fixed amounts without multiplication logic.
• Updated the controller (_extract_donation_order_line_fields) to:
  • Force the selected amount as price_unit
  • Use a fixed quantity of 1.0 (product_uom_qty)

---

Result

Administrators can now configure fixed donation amounts (e.g. 15 CHF, 50 CHF) independently of the product’s catalog price.

[gemini-code-assist]

Summary of Changes

Hello @SlWa99, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the system for managing suggested donation amounts, transitioning from a fragile quantity-based calculation to a more robust price-based approach. Previously, donation suggestions were derived by multiplying a quantity by a product's base price, leading to inconsistencies when product prices changed. The updated system allows administrators to define fixed monetary donation amounts directly, ensuring stability and ease of management.

Highlights

• Model Field Update: Replaced quantity-based integer fields for suggested donations with direct monetary fields in the product.template model.
• Backend Logic Refinement: Modified the donation controller to directly use the new monetary fields for suggested amounts and enforce a fixed quantity of 1.0 for donation order lines.
• Frontend Display Adjustment: Updated QWeb templates to display the new fixed monetary donation amounts without relying on multiplication logic.
• Admin UI Change: The product form view now allows administrators to directly input fixed donation amounts, improving configurability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully refactors the suggested donation amount logic from a quantity-based calculation to a direct price-based configuration. The changes are well-implemented across the model, controller, and view layers, improving maintainability. I've identified one area for improvement in the controller to ensure that configured donation amounts are always positive, preventing potential issues with zero or negative value donations.