Check drivesize, ignore drive not found errors if empty-state is set #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 13, 2026 13:32
- use error types and typecasting to see if no drives are found - return OK state if no drives are found - write non-existent drive tests for check_drivesize - also test customizing empty state result using empty-state= argument
- also report ok for windows partition not found errors - add more tests for windows
fix the misunderstood condition about how drive/directory discovery errors are handled. previously, if the drive was not found the errors were always ignored, the check would not have any items in its list and the empty-state override would function since the list is empty corrected it so that the errors are ignored only when empty-state is set. if empty-state is set, it will ignore discovery errors, produce and empty list and the override will function. but if its not, it returns the error just as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old one #290