My first official commit #1
Conversation
| #vision{ | ||
| float:left; | ||
| width:33.33%; | ||
| height:250px; |
There was a problem hiding this comment.
So far everything looks good. I'll have to see how it turned out tomorrow. The only critique I have is a small one. Make sure your code is neat. Have everything lined up evenly and uniformed. Might seem like a petty thing to critique right now but once we start getting into LESS and even JSX you will see how important it is to have neat code.
great-idea-website/index.html
Outdated
| <img class="logo" src="img/logo.png" alt="Great Idea! Company logo."> | ||
| </container> | ||
| </nav> | ||
| </container> |
There was a problem hiding this comment.
As I am sure container worked as far making an actual container, a rule of thumb is the only thing called container is the class of the body. In this instance you should replace the first container with header and the second container with div.
| <h1>On</h1> | ||
| <h1>Demand</h1> | ||
| <button id="started"> | ||
| <p>Get Started</p> |
There was a problem hiding this comment.
To save code space, you don't need to put p tags here. You could just put button and it would still work.
No description provided.