Skip to content

Fix GetSettings - Ignore nameless values & trim values. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharlesNRU wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix GetSettings - Ignore nameless values & trim values. #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dee5039
Fix GetSettings - Ignore nameless values & trim values.
CharlesNRU Nov 3, 2020
3331a04
Trimming values when getting current values
CharlesNRU Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions HP/Manage-HPBiosSettings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ Function Set-HPBiosSetting
if($NULL -ne $CurrentSetting)
{
#Split the current values
$CurrentSettingSplit = $CurrentSetting.Split(',')
$CurrentSettingSplit = $CurrentSetting.Split(',') | ForEach-Object{$_.Trim()}
#Find the currently set value
$Count = 0
while($Count -lt $CurrentSettingSplit.Count)
Expand Down Expand Up @@ -420,10 +420,10 @@ if($SetSettings)
#Get the current settings
if($GetSettings)
{
$SettingList = $SettingList | Select-Object Name,Value | Sort-Object Name
$SettingList = $SettingList | Where-Object{$_.Name -ne " "} | Select-Object Name,Value | Sort-Object Name
$SettingObject = ForEach($Setting in $SettingList){
#Split the current values
$SettingSplit = ($Setting.Value).Split(',')
$SettingSplit = ($Setting.Value).Split(',') | ForEach-Object{$_.Trim()}
#Find the currently set value
$SplitCount = 0
while($SplitCount -lt $SettingSplit.Count)
Expand Down