Skip to content

Conversation

@n0cte
Copy link
Contributor

@n0cte n0cte commented Dec 4, 2023

Description

Please add a description of the changes that this PR introduces and the files that
are the most critical to review.

Closes: #XXX

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I[2024-01-12|08:45:44.758] R.URL.PATH module=rpc path=/ext/bc/2QAdREospcgYUQwtsV1DCy4rr353hSUsYWpFKnTozovdahnpLS/rpc
So, I think that we should delete this block of code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mentioned the block of code on lines 70-77

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please: change field name from 'st' to 'status',
get rid of panic on line 54,
explain trick on line 100

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to build variable of virtual machine for debug purposes, at the same time it doesn't matter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of panics, implement methods

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines: 140,154,175, 189,208,225,250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants