-
Notifications
You must be signed in to change notification settings - Fork 11
Vm reimpl new service #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 0.34.19-lanslide-core
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I[2024-01-12|08:45:44.758] R.URL.PATH module=rpc path=/ext/bc/2QAdREospcgYUQwtsV1DCy4rr353hSUsYWpFKnTozovdahnpLS/rpc
So, I think that we should delete this block of code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've mentioned the block of code on lines 70-77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please: change field name from 'st' to 'status',
get rid of panic on line 54,
explain trick on line 100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to build variable of virtual machine for debug purposes, at the same time it doesn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get rid of panics, implement methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines: 140,154,175, 189,208,225,250
Description
Please add a description of the changes that this PR introduces and the files that
are the most critical to review.
Closes: #XXX