[CDX-352] Add preFilterExpression to RecommendationRequest #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for pre-filter expressions in recommendation requests, enabling filtering of recommendation results based on specified criteria.
Changes:
- Added
PreFilterExpressionproperty toRecommendationsRequestclass - Updated
GetRequestParametersmethod to include pre-filter expression in request parameters - Added comprehensive test coverage for the new functionality
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/constructor.io/models/Recommendations/RecommendationsRequest.cs | Added PreFilterExpression property and logic to serialize it into request parameters |
| src/Constructorio_NET.Tests/models/Recommendations/RecommendationsRequestTest.cs | Added unit test to verify pre-filter expression is correctly added to request parameters |
| src/Constructorio_NET.Tests/client/modules/RecommendationsTests.cs | Added integration tests for pre-filter expression functionality with both object-based and JSON-based expressions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…s.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Nice!! Thank you! |
HHHindawy
requested changes
Jan 20, 2026
Contributor
HHHindawy
left a comment
HHHindawy
left a comment
There was a problem hiding this comment.
Just left a single comment that's causing tests to fail
| 'value': 'XYZ' | ||
| }" | ||
| ); | ||
| JsonPreFilterExpression preFilterExpression = new JsonPreFilterExpression( |
Contributor
There was a problem hiding this comment.
I don't think JsonPreFilterExpression with an upper-case F is a valid class name.
We could either use JsonPrefilterExpression now instead, or rename it everywhere to be JsonPreFilterExpression.
Mudaafi
previously requested changes
Jan 20, 2026
src/Constructorio_NET.Tests/client/modules/RecommendationsTests.cs
Outdated
Show resolved
Hide resolved
…s.cs Co-authored-by: Ahmad Mudaafi' <ahmad.mudaafi@constructor.io>
esezen
deleted the
cdx-352-net-sdk-add-prefilterexpression-to-recommendationsrequest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.