Skip to content

[CI-4396] Add optional price attribute to ItemTracked type #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esezen merged 3 commits into from
May 8, 2025
Merged

[CI-4396] Add optional price attribute to ItemTracked type #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9d8e5a
Add optional price attribute to ItemTracked type
TarekAlQaddy May 5, 2025
162877e
Specify cspell version to be v8.19.4 in spell-check github action
TarekAlQaddy May 5, 2025
4ebce85
Update the error message to match the api response
TarekAlQaddy May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/spell-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ jobs:
node-version: ${{ matrix.node }}

- name: Spell check
run: npx cspell "**/*.js"
run: npx cspell@v8.19.4 "**/*.js"
2 changes: 1 addition & 1 deletion spec/src/modules/tracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4540,7 +4540,7 @@ describe('ConstructorIO - Tracker', () => {

// Response
expect(responseParams).to.have.property('method').to.equal('POST');
expect(responseParams).to.have.property('message').to.equal('conversion type must be one of add_to_wishlist, add_to_cart, like, message, make_offer, read. If you wish to use custom types, please set is_custom_type to true and specify a display_name.');
expect(responseParams).to.have.property('message').to.equal('Invalid parameters');
Copy link
Contributor Author

@TarekAlQaddy TarekAlQaddy May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API now returns Invalid parameters instead and the full descriptive message is inside errors[0].message. After discussing with Jimmy, we decided to just change the error message for now to keep it simple in the tests


done();
});
Expand Down
2 changes: 1 addition & 1 deletion src/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,9 @@ export interface ItemTracked {
itemName?: string;
itemId?: string;
variationId?: string;
price?: number;
}

export interface ItemTrackedPurchased extends ItemTracked {
price: number,
count: number
}