Skip to content

Conversation

@Manuthor
Copy link
Contributor

@Manuthor Manuthor commented Dec 6, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates major HTTP client dependencies to their latest versions, primarily upgrading rustls from 0.21 to 0.23, reqwest from 0.11 to 0.12, and oauth2 from 4.4 to 5.0. The changes adapt the codebase to breaking API changes in these libraries, particularly around TLS configuration, certificate verification, and OAuth2 client initialization.

Key Changes:

  • Migrated to rustls 0.23's new crypto provider model with aws-lc-rs as the default provider
  • Updated ServerCertVerifier trait implementation to include new required signature verification methods
  • Refactored OAuth2 client initialization to use builder pattern instead of constructor parameters
  • Modified test expectations to reflect new error handling behavior with fallback to defaults

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
deny.toml Updated allowed licenses and removed MPL-2.0
crate/http_client/Cargo.toml Updated dependency versions for rustls, reqwest, oauth2, and related crates
crate/http_client/src/tls.rs Migrated to rustls 0.23 API with new crypto provider and certificate types
crate/http_client/src/certificate_verifier.rs Implemented new ServerCertVerifier methods for TLS 1.2/1.3 signature verification
crate/http_client/src/login.rs Updated oauth2 client to use builder pattern and removed unused HTTP client abstraction
crate/http_client/src/tests.rs Updated test expectations to match new fallback behavior for invalid cipher suites
Cargo.lock Dependency lock file updates for the entire dependency tree
.pre-commit-config.yaml Updated cargo-deny version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Manuthor Manuthor merged commit 755c59b into develop Dec 6, 2025
11 checks passed
@Manuthor Manuthor deleted the chore/update_http_client_deps branch December 6, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants