Performance getNearestWaypoints #1119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will speed up the function getNearestWaypoints by 5x. Idea is to catch up the waypoints in a distance of 50m around the looking position with simple distance function instead of performing complex calculations on all waypoints. After that the complex calculations are performed on the catched waypoints to find the suitable nearest waypoint. In case less then 10 waypoints are found the existing approach is followed. Possible further improvements: - consider workwith instead of fixed 50m - consider number of workers(multitools) on same course Remark: I will not invest more time on this, so leave it up to you: Take it, improve it or drop it.
Contributor
|
Thanks for the pull request, never thought that the getDeltaAngle is so expensive to call. There are a few issues but since you don't seem to be ready to spend more time on this, I'm closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will speed up the function getNearestWaypoints by 5x.
Idea is to catch up the waypoints in a distance of 50m around the looking position with simple distance function instead of performing complex calculations on all waypoints. After that the complex calculations are performed on the catched waypoints to find the suitable nearest waypoint. In case less then 10 waypoints are found the existing approach is followed.
Possible further improvements:
Remark:
I will not invest more time on this, so leave it up to you: Take it, improve it or drop it.