Skip to content

Improve noPlayers performance #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RVSkeLe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve noPlayers performance #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 18 additions & 27 deletions paper/src/main/java/com/badbones69/blockparticles/Particles.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import org.bukkit.entity.Entity;
import org.bukkit.entity.LivingEntity;
import org.bukkit.entity.Player;
import org.bukkit.util.NumberConversions;
import org.bukkit.util.Vector;
import java.util.ArrayList;
import java.util.Collection;
Expand Down Expand Up @@ -1114,37 +1115,27 @@ private ArrayList<Location> getCircleReverse(Location center, double radius, int

return locations;
}

private Collection<Entity> getNearbyEntities(Location location, double x, double y, double z) {
final World world = location.getWorld();

try {
return world.getNearbyEntities(location, x, y, z);
} catch (Exception ignored) {}

return new ArrayList<>();
}

private boolean noPlayers(Location location, int range) {
try {
Collection<Entity> out = getNearbyEntities(location, range, range, range);

if (!out.isEmpty()) {
for (Entity e : out) {
if (e instanceof LivingEntity en) {
if (en instanceof Player) {
return false;
}
}
}
}
} catch (Exception ignored) {}

private boolean noPlayers(Location location, double range) {
double rangeSquared = range * range;
World world = location.getWorld();

for (Player player : world.getPlayers()) {
if (distanceSquared(player.getX(), player.getY(), player.getZ(), location) <= rangeSquared) {
return false;
}
}
return true;
}


private static double distanceSquared(double x, double y, double z, Location location) {
return NumberConversions.square(x - location.getX())
+ NumberConversions.square(y - location.getY())
+ NumberConversions.square(z - location.getZ());
}

private int randomColor() {
return random.nextInt(255);
}

}
}