Skip to content

Conversation

@JacekWalczak92
Copy link

No description provided.

<DelegateContainer id="delegate">
<Delegate>{t('components.balanceBanner.delegated_to')}</Delegate>
<TezosAddress address={delegatedAddress} color="white" size={ms(-1)} weight={300} />
<TezosAddress id="tezosAddres" address={delegatedAddress} color="white" size={ms(-1)} weight={300} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

}

// [TESTING]
if (ipcRenderer.sendSync('is-spectron')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this code need to live in the release?

"include": [
"src",
"./test"
"./test", "test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this duplicated?

test/spec.js Outdated
@@ -0,0 +1,102 @@
const assert = require('assert');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests should be organized in a directory structure similar to the code. Consider how ConseilJS does it: code vs tests.

@anonymoussprocket anonymoussprocket changed the base branch from release/005 to release/006 November 26, 2020 17:24
Base automatically changed from release/006 to develop November 26, 2020 17:25
@vishakh
Copy link
Contributor

vishakh commented May 7, 2021

Closing in favor of #346.

@vishakh vishakh closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants