Skip to content

Conversation

@RaghavaAlajangi
Copy link
Member

@RaghavaAlajangi RaghavaAlajangi commented Oct 16, 2025

This PR aims to implement issue #211

  • Implement logic
  • Passed CICD
  • Update CHANGELOG

@RaghavaAlajangi
Copy link
Member Author

Before Zoom-in contour plot

image

After Zoom-in

image

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.39%. Comparing base (544e5e3) to head (3faf974).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dcscope/gui/pipeline_plot.py 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   78.51%   78.39%   -0.12%     
==========================================
  Files          67       67              
  Lines        7657     7671      +14     
==========================================
+ Hits         6012     6014       +2     
- Misses       1645     1657      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmueller
Copy link
Member

Looks good to me. I think a test is not necessary. Please just correct the version in the changelog and I will merge 👍

@paulmueller
Copy link
Member

Oh wait, you still have to update the dcscope/pipeline/plot DEFAULT_STATE and STATE_OPTIONS.

Could you please also do a quick manual test and see whether opening sessions created after the change works with the version from before the change? And the other way around as well?

@RaghavaAlajangi
Copy link
Member Author

In both cases, its working fine. I can open the sessions.

@RaghavaAlajangi
Copy link
Member Author

Paul, I changed the zoomin_contours logic a bit. Please have a look.

@RaghavaAlajangi
Copy link
Member Author

How do users know about this option? adding some indication would be nice I think.

@RaghavaAlajangi
Copy link
Member Author

Hi Paul,
Please review my changes.

@paulmueller paulmueller merged commit f227e20 into DC-analysis:main Oct 17, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants