Skip to content

Conversation

@homework36
Copy link
Contributor

Resolves: (#ID-of-the-issue)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

Make production release v3.3.0

Fix

  • Now support optional RGB Image input and output in Column Split job
  • MEI Encoding job is now able to encode a variable number of lines, rather than hard coded 4, with a temporary fix for pitch errors due to a different number of lines than 4 by adjusting the clef position
  • [frontend] Workflow job position x offset after reload
  • [frontend] Hide dropdown menus on click away
  • [frontend] Tab & navigation status

Add

  • Aquitanian Ref Line Finding job
  • [frontend] Delete confirm window for workflow (in addition to project)

Update

  • Nginx Dockerfile with Debian archive
  • Use DDMAL forked version of Calamri for Text Alignment job

yinanazhou and others added 30 commits February 7, 2025 11:03
- Add `REQUEST__PROJECT_DELETE_CONFIRM` and view
- Require delete confirm for project, resource, and multiple resources

refs: #1253, #1079
fix: add delete confirm window
- Pass `layer` and `surface` to `SylMachine`
- Only generate `zone` and insert to `surface` when the `syllable` is inserted into `layer` to avoid ghost `zones`

refs: #1117
… Finding to Aquitanian Reference Line Finding
- The workflow job items were shifting right by ~26px (approximately half the job width) after page reload due to saving center positions without accounting for dynamic text width. Changed to use top-left position coordinates instead of center coordinates to ensure consistent positioning regardless of job text width.

refs: #1128
- Corrected `h3` when deleting single project

refs: #1282
style: fix workflow job position x offset after reload
fix: add delete confirm window for workflow
…es and changes clef's offset based on staff lines
- Changed tab sequence to be the same with navigation
- Changed default content from workflow run to resource
- Moved tab active status update from on-click to show-view
- Fixed tab & navigation status sync

refs: #1121
fix: hide dropdown menus on click away
fix: tab & navigation status
DeannaLC and others added 21 commits May 7, 2025 17:33
... for calamari and tfaip
Modifies build_mei_file.py in the MEI Encoding job to be able to encode a variable number of lines, rather than 4 which was previously hard coded in. Additionally implements a temporary fix for pitch errors due to a different number of lines than 4 by adjusting the clef position.
Update prod tag in Makefile to v3.2.0
Debian Buster repositories have moved to archive.debian.org.
Update sources.list URLs and disable expired metadata checks to
allow apt-get update and package installation.
Aquitanian Staff Finding job - given a classified layer from Aquitanian notation (one line per staff), outputs the coordinates for the classified line plus 2 ledger lines above and 2 ledger below for each staff. Draws bounding boxes around each line, separates the line into segments to get each segment's slope, and connects them together.
Fix dockerfile debian repo for nginx image
Added an extra input and output for an RGB image in Column Splitting, mainly to be used as an input for Interactive Classifier.
Release v3.3.0

Fix
- Now support optional RGB Image input and output in `Column Split` job
- `MEI Encoding` job is now able to encode a variable number of lines, rather than hard coded 4, with a temporary fix for pitch errors due to a different number of lines than 4 by adjusting the clef position
- [frontend] Workflow job position x offset after reload
- [frontend] Hide dropdown menus on click away
- [frontend] Tab & navigation status

Add
- `Aquitanian Ref Line Finding` job
- [frontend] Delete confirm window for workflow (in addition to project)

Update
- Nginx Dockerfile with Debian archive
- Use DDMAL forked version of `Calamri` for `Text Alignment` job
@github-actions
Copy link

SHA: 3b07489

details
- docs: comment in build_mei_file.py line 251 about resolving issue https://github.com/DDMAL/Rodan/issues/1276
- fix: Modifies MEI Encoding to read from JSOMR for number of staff lines and changes clef's offset based on staff lines

details
- docs: comments in aquitanian_ref_line_finding.py to document functions and overall workflow
- fix: sorts staff lines based on y height
- docs: updated setting for neume height to be 3 * neume height
- fix: changes bounding box size to surround whole staff section
- fixed json formatting error
- Revert "fixed json formatting error"
- Fixed MEI Encoding to handle different num_lines
- fixed json formatting error
- Removed branch for 1 line from Miyao Staff Finding, renamed One Staff Finding to Aquitanian Reference Line Finding
- Added if case for 1 staff to Miyao Staff Finding
- Added job for single staff finding

details
- upload sample yml for new production setting
- comment out slow start script
- update version number

details
- fix: removed RGB Image from All Layers output
- docs: updated image port name, added comment on 3 and 4 channels working for get_stacked_images
- fix: adds an image input to column splitting to be used with interactive classifier

details
- fix: hide dropdown menus on click away

details
- test: update MEI encoding test result
- fix: generate zone for syl only when syllable gets inserted
- fix: add `liquescent` element inside `nc`
- fix: group all-zero dummy syl to first syllable
- fix: update to MEI v5.1

details
- use packaged calamari release instead of branch
- add direct tensorflow link before calamari install
- use temporary test branch for calamari
- use DDMAL forked packages

details
- fix FromAsCasing mismatch
- force default setting for debian package install to prevent potential time out during auto build
- point apt sources to Debian archive for buster

details
- style: fix workflow job position x offset after reload
- chore: reformat

details
- fix: tab & navigation status

details
- fix: add delete confirm window for workflow
- chore: reformat

details
- fix: add delete confirm window
- chore: format using prettier

details
- Update prod tag in Makefile to v3.2.0

@homework36 homework36 merged commit 6a5d7d4 into master Jul 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants