Skip to content

Improve error logging for proxy debugging #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeeGordon83 merged 1 commit into from
Jan 19, 2026
Merged

Improve error logging for proxy debugging #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions src/lib/flood-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,24 @@ export function proxyFetch (url, options = {}) {
const proxyUrlConfig = config.get('httpProxy') // bound to HTTP_PROXY

if (!proxyUrlConfig) {
console.log(`[PROXY] No HTTP_PROXY set - using direct fetch for: ${url}`)
return fetch(url, options)
}

return fetch(url, {
...options,
dispatcher: new ProxyAgent({
uri: proxyUrlConfig,
keepAliveTimeout: 10,
keepAliveMaxTimeout: 10
console.log(`[PROXY] Using proxy ${proxyUrlConfig} for: ${url}`)
try {
return fetch(url, {
...options,
dispatcher: new ProxyAgent({
uri: proxyUrlConfig,
keepAliveTimeout: 10,
keepAliveMaxTimeout: 10
})
})
})
} catch (error) {
console.error(`[PROXY] Error setting up proxy for ${url}:`, error)
throw error
}
}

/**
Expand All @@ -35,7 +42,8 @@ export async function getStation (stationId) {
console.log(`Station API response status: ${response.status} ${response.statusText}`)

if (!response.ok) {
throw new Error(`Failed to fetch station: ${response.status} ${response.statusText}`)
const errorText = await response.text().catch(() => 'Unable to read error response')
throw new Error(`Failed to fetch station: ${response.status} ${response.statusText} - ${errorText}`)
}
const data = await response.json()
// The API returns an array of stations in items
Expand All @@ -46,7 +54,12 @@ export async function getStation (stationId) {
console.log(`No station items found for ${stationId}`)
return null
} catch (error) {
console.error(`Error fetching station from ${url}:`, error.message, error.cause)
console.error(`Error fetching station from ${url}:`, {
message: error.message,
cause: error.cause?.message || error.cause,
code: error.cause?.code,
stack: error.stack?.split('\n').slice(0, 5).join('\n')
})
return null
}
}
Expand Down
7 changes: 2 additions & 5 deletions src/routes/health-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,8 @@ export const healthCheck = {
const testUrl = 'https://environment.data.gov.uk/flood-monitoring/id/stations?RLOIid=8085'
request.logger.info(`Testing connectivity to: ${testUrl}`)

const controller = new AbortController()
const timeoutId = setTimeout(() => controller.abort(), 5000)

const response = await proxyFetch(testUrl, { signal: controller.signal })
clearTimeout(timeoutId)
// No timeout - let it fail naturally to see the real error
const response = await proxyFetch(testUrl)

results.externalApis.environmentAgency = {
url: testUrl,
Expand Down