Feature/fsr 1136 update to aws sdk v3 #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddmason
approved these changes
Aug 26, 2025
|
teddmason
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: After the AWS SDK upgrade, parallel PutObject calls caused EMFILE (too many open files).
Fix: Use bounded concurrency (default 5) with SDK v3 s3.send(new PutObjectCommand(...)) and a keep-alive HTTP agent.
Also: clearer logs and correct per-station key in error messages.
Testing: Ran locally and in test by uploading the CSV; uploads completed, no EMFILE.
Impact: No API changes. Slightly slower, much more reliable.