-
Notifications
You must be signed in to change notification settings - Fork 63
Add element print in release #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enhancement-standalone_type_uint8
Are you sure you want to change the base?
Add element print in release #1910
Conversation
c5a9af0 to
f6c2e8a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## enhancement-standalone_type_uint8 #1910 +/- ##
=====================================================================
- Coverage 76.15% 76.00% -0.15%
=====================================================================
Files 103 103
Lines 19424 19470 +46
=====================================================================
+ Hits 14792 14798 +6
- Misses 4632 4672 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
An alternative approach is suggested in PR #2033 |
spenke91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You said in the description that you're open to have a combined function for debug and release. Without having looked much into it, this seems like the much cleaner option to me too.
But maybe there are reasons I am not aware of yet that made you go for the two separated functions in this first version of the PR? 🤔 Could you comment on that?
| * Print a given element. For a example for a triangle print the coordinates | ||
| * and the level of the triangle. This function is only available in the | ||
| * debugging configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Print a given element. For a example for a triangle print the coordinates | |
| * and the level of the triangle. This function is only available in the | |
| * debugging configuration. | |
| * Print a given element. For a example for a triangle print the coordinates | |
| * and the level of the triangle. |
Closes #1912
Describe your changes here:
Sometimes, weird stuff only happens in Release mode.
In order to manually find the error with print statements, this PR helps by introducing a print function that is available in release.
I am also open to just have one implementation, that works in both modes but only prints with DEBUG priority.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).