Skip to content

Fix :creator & :commenter traits in plans factory #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aaronskiba wants to merge 2 commits into
base: development
Choose a base branch
from
Draft

Fix :creator & :commenter traits in plans factory #3526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9c1ed9
Fix creator & commenter traits in plans factory
aaronskiba May 20, 2025
f6f0443
Update CHANGELOG.md
aaronskiba May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Changelog

- Fix `:creator` & `:commenter` traits in plans factory [#3526](https://github.com/DMPRoadmap/roadmap/pull/3526)
- Updated seeds.rb file for identifier_schemes to include context value and removed logo_url and idenitifier_prefix for Shibboleth (as it was causing issues with SSO). [#3525](https://github.com/DMPRoadmap/roadmap/pull/3525)
- Adjustments to style of select tags and plan download layout [#3509](https://github.com/DMPRoadmap/roadmap/pull/3509)
- Fix failing eslint workflow / upgrade `actions/checkout` & `actions/setup-node` to v3 [#3503](https://github.com/DMPRoadmap/roadmap/pull/3503)
Expand Down
8 changes: 4 additions & 4 deletions spec/factories/plans.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,13 @@
guidance_groups { 0 }
end
trait :creator do
after(:create) do |obj|
obj.roles << create(:role, :creator, user: create(:user, org: create(:org)))
after(:create) do |plan|
plan.roles << create(:role, :creator, user: create(:user, org: create(:org)), plan: plan)
end
end
trait :commenter do
after(:create) do |obj|
obj.roles << create(:role, :commenter, user: create(:user, org: create(:org)))
after(:create) do |plan|
plan.roles << create(:role, :commenter, user: create(:user, org: create(:org)), plan: plan)
end
end
trait :organisationally_visible do
Expand Down