feat(function-lint): add Self-return patterns and MustNotExist rule for builder-style APIs #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces three new
ReturnTypePatterns (SelfValue,SelfRef,SelfMutRef) and theMustNotExistrule. This lets us do things like assert how builders should look:builder .function_lint() .lint_named("builder_style_with_consuming_forbidden") // forbid any `with_*` method that returns `Self` .matching(|m| m.name_regex("^with_").and(m.returns_self())) .with_severity(Severity::Error) .must_not_exist() .build();The rule forces code to follow the consuming-builder pattern:
and not this: