Support CDK Aspects #251
Open
Support CDK Aspects #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
reviewed
Feb 15, 2024
v2/src/datadog.ts
Outdated
| constructor(private datadog: Datadog) {} | ||
|
|
||
| visit(node: IConstruct): void { | ||
| if (node.constructor.name === lambda.Function.name) { |
Contributor
There was a problem hiding this comment.
It seems that this condition might not instrument lambda.SingletonFunction, is this intentional?
Contributor
Author
There was a problem hiding this comment.
Ah that's a miss, good call
Contributor
There was a problem hiding this comment.
I think the interfaces differ, so LambdaFunction.name might or might not work 🤔
Contributor
Author
There was a problem hiding this comment.
That's what I seemed to run into.
drichards-87
approved these changes
Feb 15, 2024
duncanista
approved these changes
Feb 15, 2024
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
LGTM – thanks a lot for this PR, AJ! 🎉
Contributor
Author
|
holding off on merging this because apparently this issue still remains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows our construct to be imported and used as an Aspect, which makes it easier to instrument all functions in a stack without re-importing or re-declaring the Datadog construct.
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply