feat: grant decrypt permissions for encrypted secrets passed to apiKeySecret #525
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchungy
force-pushed
the
add-grant-decrypt
branch
from
a029ee9 to
b5d8607
Compare
samchungy
force-pushed
the
add-grant-decrypt
branch
from
b5d8607 to
3c121bb
Compare
samchungy
changed the title
samchungy
commented
Jan 16, 2026
| const CUSTOM_EXTENSION_LAYER_ARN = "arn:aws:lambda:us-east-1:123456789:layer:Datadog-Extension-custom:1"; | ||
| const NODE_LAYER_VERSION = 91; | ||
| const REPO_REGEX = /git\.repository_url:.*\/DataDog\/datadog-cdk-constructs(\.git)?/; | ||
| const REPO_REGEX = /git\.repository_url:.*\/[^/]+\/datadog-cdk-constructs(\.git)?/; |
Contributor
Author
There was a problem hiding this comment.
This was causing my fork PR to fail. I've changed it so people can fork and still have their tests work? Unless you don't want forks?
nina9753
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #249
Grants permissions to the Lambda to decrypt the KMS key in order to access a secret.
Motivation
We couldn't figure out why our Lambda could not hit DataDog and discovered it was because of the lacking permission.
Testing Guidelines
Locally + Unit Tests
Additional Notes
Could be a fix, could be a feature. I don't mind really.
Types of Changes
Check all that apply