Fixing thread leaks #567
Fixing thread leaks #567
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| public Set<ObjectName> queryNames(ObjectName name) throws IOException { | ||
| String scope = (name != null) ? name.toString() : "*:*"; | ||
| public Set<ObjectName> queryNames(final ObjectName name) throws IOException { | ||
| final String scope = (name != null) ? name.toString() : "*:*"; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Avoid negation in your if condition (...read more)
Using a negative comparison in if expressions with an else clause can be confusing. Consider modifying your comparison by switching your if and else` block statements.
| private Socket socket = null; | ||
| private boolean shouldClose = false; | ||
|
|
||
| private volatile Exception exception = null; |
There was a problem hiding this comment.
🟠 Code Quality Violation
| private volatile Exception exception = null; | |
| private volatile Exception exception; |
Remove initialization, this is already the default value. (...read more)
When initializing fields, prevent initializing fields to the default value. Any additional initialization means more bytecode instructions, and allocating many of these objects may impact your application performance.
If you initialize to a default value, remove the initialization.
| private boolean shouldClose = false; | ||
|
|
||
| private volatile Exception exception = null; | ||
| private volatile Socket socket = null; |
There was a problem hiding this comment.
🟠 Code Quality Violation
| private volatile Socket socket = null; | |
| private volatile Socket socket; |
Remove initialization, this is already the default value. (...read more)
When initializing fields, prevent initializing fields to the default value. Any additional initialization means more bytecode instructions, and allocating many of these objects may impact your application performance.
If you initialize to a default value, remove the initialization.
|
|
||
| private volatile Exception exception = null; | ||
| private volatile Socket socket = null; | ||
| private volatile boolean shouldClose = false; |
There was a problem hiding this comment.
🟠 Code Quality Violation
| private volatile boolean shouldClose = false; | |
| private volatile boolean shouldClose; |
Remove initialization, this is already the default value. (...read more)
When initializing fields, prevent initializing fields to the default value. Any additional initialization means more bytecode instructions, and allocating many of these objects may impact your application performance.
If you initialize to a default value, remove the initialization.
carlosroman
force-pushed
the
carlosroman/AGTMETRICS-303-memory-leak
branch
from
bd24e79 to
e130317
Compare
No description provided.