Feature: WebSphere PMI subcollections support for connection pool metrics #584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that I experimented with over the weekend to add support for WebSphere PMI subCollections support so that connection pool metrics could be retrieved. I would be interesting in discussing the possibility of adding this to jmxfetch.
WebSphere connection pool statistics (
type:JDBCProvider) are little tricky to gather over JMX because the statistics are exposed using a non-standardsubCollectionsmethod on a non-standardStatsImplobject (docs) and the sub-collection objects use non-standard statistics value objects (com.ibm.ws.pmi.stat.CountStatisticImpl, etc.). This PR adds support for both (1) the non-standard attribute objects inPmiSubCollectionAttribute, following the existing pattern and reusing code fromJmxTabularAttributeand (2) statistics objects inPmiStatisticsAttributes, mirroring the patterns inJeeStatisticsAttributes.You can see the configuration for this here: deejgregor/dd-trace-java@a8d6cb7
And here is a docker compose setup to test this: https://github.com/deejgregor/websphere-setup/tree/feature-pmi-subcollections