-
Notifications
You must be signed in to change notification settings - Fork 16
feat(telemetry): add process_tags to Application in telemetry #1459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
BenchmarksComparisonBenchmark execution time: 2026-01-20 10:42:54 Comparing candidate commit 3b283c5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
+ Coverage 71.13% 71.19% +0.06%
==========================================
Files 416 416
Lines 67015 67062 +47
==========================================
+ Hits 47668 47744 +76
+ Misses 19347 19318 -29
🚀 New features to boost your workflow:
|
5d8673a to
3b283c5
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
What does this PR do?
This PR adds a
process_tagsfield to the telemetryApplicationstruct. This tag can be set during configuration or later (when the process_tags are acquired).Motivation
dd-trace-phpneeds to be send the process_tags for its telemetry according to this RFC.It is important to note that the tracer will set the configuration of its sidecar before we can retrieve the process_tags. That's why I created a function specifically to set the processs_tags.
How to test the change?
A PR will be opened soon in dd-trace-php to test the functionnality.