Skip to content

fix(profiling-ffi): Windows extern statics need __declspec(dllimport) #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
morrisonlevi wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

fix(profiling-ffi): Windows extern statics need __declspec(dllimport) #1468

morrisonlevi wants to merge 7 commits into from
+75 −7

Conversation

@morrisonlevi
Copy link
Contributor

@morrisonlevi morrisonlevi commented Jan 22, 2026

What does this PR do?

On the FFI headers on windows, this attends to replace "extern " with "extern __declspec(dllimport) ".

Motivation

These static variables result in a crash if you use them when they don't have __declspec(dllimport) .

Additional Notes

This went unfound because none of the examples run on Windows in CI. I am planning to look into running these as part of CI (this is in draft still).

How to test the change?

Build and note you don't get a crash anymore when using these static vars on Windows 😆

@morrisonlevi morrisonlevi changed the title fix(profiling): Windows extern statics need __declspec(dllimport) fix(profiling-ffi): Windows extern statics need __declspec(dllimport) Jan 22, 2026
@morrisonlevi morrisonlevi added bug Something isn't working profiling Relates to the profiling* modules. labels Jan 22, 2026
@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-01-29 10:36:52

Comparing candidate commit 2bc74c6 in PR branch levi/fix-windows-declspec-vars with baseline commit cd903df in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 48.814ms 49.203ms ± 0.981ms 49.074ms ± 0.042ms 49.118ms 49.262ms 52.188ms 61.315ms 24.95% 10.318 118.071 1.99% 0.069ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [49.067ms; 49.339ms] or [-0.276%; +0.276%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.632ms 10.657ms ± 0.014ms 10.656ms ± 0.008ms 10.664ms 10.679ms 10.691ms 10.740ms 0.80% 1.588 6.813 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.655ms; 10.659ms] or [-0.018%; +0.018%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 188.274ns 191.519ns ± 2.888ns 191.335ns ± 1.604ns 192.611ns 196.356ns 201.153ns 211.307ns 10.44% 2.329 10.870 1.50% 0.204ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [191.119ns; 191.919ns] or [-0.209%; +0.209%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 147.527µs 149.305µs ± 1.597µs 149.103µs ± 0.505µs 149.585µs 150.994µs 154.945µs 164.604µs 10.40% 5.852 47.487 1.07% 0.113µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [149.084µs; 149.526µs] or [-0.148%; +0.148%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 539.458µs 540.134µs ± 0.368µs 540.097µs ± 0.214µs 540.303µs 540.752µs 541.504µs 542.332µs 0.41% 1.977 7.513 0.07% 0.026µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [540.083µs; 540.185µs] or [-0.009%; +0.009%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.918µs 3.923µs 3.925µs 0.33% -0.230 8.667 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 254788925.759op/s 255609878.782op/s ± 210079.122op/s 255631145.752op/s ± 104742.880op/s 255731672.372op/s 255862371.611op/s 255920495.213op/s 256929303.948op/s 0.51% 0.257 8.780 0.08% 14854.837op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.209µs 77.821µs ± 0.460µs 77.721µs ± 0.186µs 78.016µs 78.434µs 78.799µs 81.476µs 4.83% 3.514 22.523 0.59% 0.033µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12273517.916op/s 12850488.320op/s ± 74540.224op/s 12866532.278op/s ± 30873.410op/s 12891265.523op/s 12932806.474op/s 12938576.266op/s 12951822.834op/s 0.66% -3.306 20.445 0.58% 5270.790op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.663µs 71.214µs ± 0.298µs 71.191µs ± 0.215µs 71.408µs 71.701µs 72.133µs 72.254µs 1.49% 0.794 0.912 0.42% 0.021µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13840013.954op/s 14042344.980op/s ± 58601.573op/s 14046719.389op/s ± 42345.041op/s 14088645.961op/s 14125932.270op/s 14147183.020op/s 14151640.752op/s 0.75% -0.766 0.840 0.42% 4143.757op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.914µs 3.917µs 3.918µs 3.919µs 0.16% -1.106 9.065 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255194888.991op/s 255608906.173op/s ± 164402.699op/s 255610474.848op/s ± 86114.064op/s 255696419.597op/s 255825619.969op/s 255875516.776op/s 256712298.157op/s 0.43% 1.125 9.197 0.06% 11625.026op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.419µs 67.886µs ± 0.303µs 67.813µs ± 0.196µs 68.064µs 68.368µs 68.923µs 69.093µs 1.89% 1.063 1.837 0.45% 0.021µs 1 200
credit_card/is_card_number/378282246310005 throughput 14473166.944op/s 14730889.383op/s ± 65538.302op/s 14746397.586op/s ± 42454.759op/s 14770641.172op/s 14818744.897op/s 14823018.490op/s 14832609.492op/s 0.58% -1.027 1.702 0.44% 4634.258op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.718µs 45.197µs ± 0.193µs 45.222µs ± 0.128µs 45.333µs 45.465µs 45.504µs 45.544µs 0.71% -0.528 -0.450 0.43% 0.014µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21956702.175op/s 22125919.460op/s ± 94826.072op/s 22112977.696op/s ± 62443.014op/s 22186887.716op/s 22310458.396op/s 22346258.774op/s 22362220.016op/s 1.13% 0.545 -0.429 0.43% 6705.216op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.035µs ± 0.007µs 6.034µs ± 0.002µs 6.036µs 6.041µs 6.063µs 6.099µs 1.08% 6.073 50.940 0.11% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163956651.760op/s 165706406.103op/s ± 178776.328op/s 165734957.318op/s ± 58435.816op/s 165792709.266op/s 165849691.886op/s 165894351.586op/s 165912853.923op/s 0.11% -6.021 50.229 0.11% 12641.395op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.900µs 3.913µs ± 0.003µs 3.912µs ± 0.002µs 3.915µs 3.918µs 3.920µs 3.920µs 0.20% 0.272 0.167 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255089509.961op/s 255563996.694op/s ± 212525.677op/s 255606293.881op/s ± 122660.307op/s 255703514.434op/s 255841549.752op/s 255888866.634op/s 256386121.714op/s 0.31% -0.266 0.177 0.08% 15027.835op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.428µs 65.608µs ± 0.076µs 65.610µs ± 0.052µs 65.659µs 65.735µs 65.767µs 65.801µs 0.29% 0.026 -0.387 0.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15197437.057op/s 15242141.701op/s ± 17724.345op/s 15241564.606op/s ± 12128.995op/s 15254408.767op/s 15270830.884op/s 15279484.834op/s 15284031.244op/s 0.28% -0.020 -0.388 0.12% 1253.300op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 52.951µs 53.020µs ± 0.031µs 53.015µs ± 0.021µs 53.038µs 53.077µs 53.107µs 53.120µs 0.20% 0.585 0.320 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18825318.081op/s 18860980.555op/s ± 11133.224op/s 18862540.881op/s ± 7301.337op/s 18869058.989op/s 18876872.716op/s 18882153.589op/s 18885561.988op/s 0.12% -0.581 0.314 0.06% 787.238op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.891µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.917µs 3.919µs 3.920µs 0.21% -1.446 14.762 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255107283.737op/s 255622291.180op/s ± 182518.192op/s 255632653.578op/s ± 90393.042op/s 255722983.106op/s 255824960.268op/s 255897856.128op/s 256988850.483op/s 0.53% 1.477 15.008 0.07% 12905.985op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.738µs 49.806µs ± 0.034µs 49.801µs ± 0.022µs 49.826µs 49.874µs 49.904µs 49.911µs 0.22% 0.734 0.470 0.07% 0.002µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 20035693.438op/s 20078058.729op/s ± 13862.859op/s 20079869.931op/s ± 8796.362op/s 20087777.090op/s 20096815.961op/s 20103568.001op/s 20105498.854op/s 0.13% -0.730 0.462 0.07% 980.252op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.601µs 45.163µs ± 0.173µs 45.174µs ± 0.114µs 45.285µs 45.407µs 45.509µs 45.544µs 0.82% -0.480 0.205 0.38% 0.012µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 21956958.427op/s 22142341.229op/s ± 85071.273op/s 22136586.435op/s ± 55868.321op/s 22193587.280op/s 22304973.114op/s 22374493.273op/s 22421207.635op/s 1.29% 0.503 0.241 0.38% 6015.447op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.028µs 6.039µs ± 0.013µs 6.037µs ± 0.003µs 6.039µs 6.049µs 6.106µs 6.112µs 1.24% 4.281 19.003 0.21% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163609899.890op/s 165581453.702op/s ± 348512.743op/s 165641561.657op/s ± 71887.425op/s 165719132.274op/s 165813443.755op/s 165867898.797op/s 165887469.429op/s 0.15% -4.264 18.875 0.21% 24643.572op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255580763.836op/s; 255638993.728op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.757µs; 77.885µs] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12840157.762op/s; 12860818.878op/s] or [-0.080%; +0.080%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.173µs; 71.256µs] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14034223.366op/s; 14050466.594op/s] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255586121.540op/s; 255631690.806op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.844µs; 67.928µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/378282246310005 throughput [14721806.405op/s; 14739972.361op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.170µs; 45.223µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22112777.478op/s; 22139061.441op/s] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.034µs; 6.036µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/x371413321323331 throughput [165681629.423op/s; 165731182.782op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ throughput [255534542.679op/s; 255593450.708op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.597µs; 65.618µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15239685.277op/s; 15244598.124op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.015µs; 53.024µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18859437.597op/s; 18862523.513op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255596995.914op/s; 255647586.446op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [49.801µs; 49.810µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [20076137.470op/s; 20079979.988op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.139µs; 45.187µs] or [-0.053%; +0.053%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22130551.169op/s; 22154131.289op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.038µs; 6.041µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165533153.188op/s; 165629754.216op/s] or [-0.029%; +0.029%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.434µs 2.465µs ± 0.017µs 2.461µs ± 0.010µs 2.475µs 2.498µs 2.503µs 2.507µs 1.87% 0.591 -0.510 0.70% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.462µs; 2.467µs] or [-0.097%; +0.097%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.350µs 89.540µs ± 0.160µs 89.523µs ± 0.041µs 89.563µs 89.676µs 89.942µs 91.457µs 2.16% 8.934 102.852 0.18% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.517µs; 89.562µs] or [-0.025%; +0.025%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.771µs 161.829µs ± 0.238µs 161.820µs ± 0.111µs 161.941µs 162.195µs 162.446µs 162.869µs 0.65% 0.047 4.281 0.15% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.796µs; 161.862µs] or [-0.020%; +0.020%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.697µs 25.797µs ± 9.138µs 18.638µs ± 0.671µs 33.738µs 42.013µs 51.174µs 63.055µs 238.32% 0.945 0.568 35.33% 0.646µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.530µs; 27.063µs] or [-4.909%; +4.909%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.024µs 5.097µs ± 0.045µs 5.091µs ± 0.037µs 5.123µs 5.181µs 5.183µs 5.223µs 2.58% 0.395 -0.613 0.88% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.090µs; 5.103µs] or [-0.122%; +0.122%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 12.602ms 12.961ms ± 0.100ms 12.980ms ± 0.044ms 13.023ms 13.081ms 13.108ms 13.110ms 1.00% -1.319 1.596 0.77% 0.007ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [12.947ms; 12.975ms] or [-0.107%; +0.107%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.195µs 3.270µs ± 1.467µs 3.023µs ± 0.031µs 3.058µs 3.681µs 14.252µs 15.478µs 411.96% 7.283 54.614 44.76% 0.104µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.066µs; 3.473µs] or [-6.219%; +6.219%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.566ms 14.637ms ± 0.029ms 14.633ms ± 0.014ms 14.649ms 14.667ms 14.759ms 14.784ms 1.03% 1.798 7.071 0.20% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.633ms; 14.640ms] or [-0.027%; +0.027%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.963ms 3.980ms ± 0.008ms 3.979ms ± 0.003ms 3.983ms 3.987ms 3.991ms 4.061ms 2.05% 6.180 65.581 0.19% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.979ms; 3.981ms] or [-0.026%; +0.026%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 206.091µs 206.710µs ± 0.355µs 206.632µs ± 0.200µs 206.915µs 207.430µs 207.643µs 207.961µs 0.64% 0.892 0.422 0.17% 0.025µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4808594.544op/s 4837711.611op/s ± 8303.375op/s 4839524.317op/s ± 4677.004op/s 4843645.171op/s 4848368.202op/s 4850655.196op/s 4852229.291op/s 0.26% -0.883 0.401 0.17% 587.137op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.601µs 18.691µs ± 0.058µs 18.680µs ± 0.030µs 18.725µs 18.795µs 18.849µs 19.036µs 1.91% 1.554 5.540 0.31% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52532184.867op/s 53502301.664op/s ± 165385.732op/s 53533494.161op/s ± 86795.576op/s 53609747.624op/s 53736845.441op/s 53752376.908op/s 53761775.196op/s 0.43% -1.507 5.226 0.31% 11694.537op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.715µs 10.785µs ± 0.027µs 10.783µs ± 0.014µs 10.797µs 10.833µs 10.855µs 10.935µs 1.40% 1.028 4.341 0.25% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 91452091.670op/s 92724120.006op/s ± 235321.991op/s 92736403.498op/s ± 124339.565op/s 92878357.007op/s 93052091.604op/s 93280452.970op/s 93330236.574op/s 0.64% -0.988 4.160 0.25% 16639.778op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [206.661µs; 206.759µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4836560.843op/s; 4838862.379op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.683µs; 18.699µs] or [-0.043%; +0.043%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53479380.793op/s; 53525222.536op/s] or [-0.043%; +0.043%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.781µs; 10.789µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/good throughput [92691506.641op/s; 92756733.370op/s] or [-0.035%; +0.035%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.904µs 34.450µs ± 0.844µs 34.075µs ± 0.042µs 34.132µs 36.213µs 36.292µs 38.032µs 11.61% 1.827 1.852 2.44% 0.060µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.333µs; 34.567µs] or [-0.340%; +0.340%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 242.644ns 253.319ns ± 13.683ns 246.802ns ± 3.314ns 258.928ns 285.081ns 292.355ns 293.089ns 18.75% 1.524 1.174 5.39% 0.968ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.423ns; 255.216ns] or [-0.749%; +0.749%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2bc74c6 1769682076 levi/fix-windows-declspec-vars
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.843µs 536.790µs ± 1.627µs 536.218µs ± 0.709µs 537.634µs 539.659µs 541.013µs 547.188µs 2.05% 2.097 7.991 0.30% 0.115µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1827526.636op/s 1862943.061op/s ± 5609.722op/s 1864911.822op/s ± 2468.990op/s 1866794.238op/s 1868511.474op/s 1869537.976op/s 1869706.325op/s 0.26% -2.047 7.577 0.30% 396.667op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 379.947µs 380.639µs ± 0.291µs 380.615µs ± 0.173µs 380.796µs 381.049µs 381.281µs 382.668µs 0.54% 1.736 10.663 0.08% 0.021µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2613232.797op/s 2627161.427op/s ± 2006.261op/s 2627328.777op/s ± 1192.537op/s 2628393.825op/s 2630066.855op/s 2630698.564op/s 2631945.733op/s 0.18% -1.714 10.486 0.08% 141.864op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.563µs 189.871µs ± 0.153µs 189.865µs ± 0.092µs 189.956µs 190.118µs 190.303µs 190.517µs 0.34% 0.766 1.400 0.08% 0.011µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5248873.309op/s 5266742.860op/s ± 4250.786op/s 5266910.124op/s ± 2553.889op/s 5269506.727op/s 5273080.929op/s 5274199.557op/s 5275294.632op/s 0.16% -0.759 1.379 0.08% 300.576op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.481µs 36.588µs ± 0.055µs 36.578µs ± 0.035µs 36.618µs 36.693µs 36.775µs 36.798µs 0.60% 0.952 1.282 0.15% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 27175274.991op/s 27331477.911op/s ± 41068.194op/s 27338980.773op/s ± 25815.074op/s 27360536.430op/s 27386776.878op/s 27396661.059op/s 27411560.785op/s 0.27% -0.941 1.249 0.15% 2903.960op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.929µs 46.045µs ± 0.093µs 46.031µs ± 0.031µs 46.068µs 46.138µs 46.216µs 47.110µs 2.34% 7.602 82.620 0.20% 0.007µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21226920.523op/s 21717867.975op/s ± 43421.307op/s 21724374.540op/s ± 14630.564op/s 21736444.798op/s 21755868.718op/s 21766831.346op/s 21772544.543op/s 0.22% -7.441 80.110 0.20% 3070.350op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.565µs; 537.015µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1862165.607op/s; 1863720.514op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.599µs; 380.680µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2626883.379op/s; 2627439.475op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [189.850µs; 189.892µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5266153.742op/s; 5267331.978op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.580µs; 36.596µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27325786.254op/s; 27337169.568op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.032µs; 46.058µs] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21711850.200op/s; 21723885.751op/s] or [-0.028%; +0.028%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.92%. Comparing base (cd903df) to head (2bc74c6).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1468      +/-   ##
==========================================
- Coverage   70.96%   70.92%   -0.04%     
==========================================
  Files         421      421              
  Lines       68438    68472      +34     
==========================================
  Hits        48567    48567              
- Misses      19871    19905      +34
Components Coverage Δ
libdd-crashtracker 61.39% <ø> (-0.02%) ⬇️
libdd-crashtracker-ffi 16.50% <ø> (ø)
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 86.28% <ø> (ø)
libdd-data-pipeline-ffi 78.57% <ø> (ø)
libdd-common 80.97% <ø> (ø)
libdd-common-ffi 74.54% <ø> (ø)
libdd-telemetry 59.82% <ø> (+0.03%) ⬆️
libdd-telemetry-ffi 21.17% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.60% <ø> (ø)
libdd-profiling 81.49% <ø> (ø)
libdd-profiling-ffi 64.71% <ø> (ø)
datadog-sidecar 34.94% <ø> (ø)
datdog-sidecar-ffi 10.25% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 93.43% <ø> (ø)
libdd-trace-normalization 82.33% <ø> (ø)
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 61.18% <ø> (ø)
libdd-trace-utils 89.45% <ø> (ø)
datadog-tracer-flare 63.49% <ø> (ø)
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the profiling Relates to the profiling* modules. label Jan 22, 2026
@dd-octo-sts
Copy link

dd-octo-sts bot commented Jan 26, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.44 MB 8.44 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 91.81 MB 91.81 MB 0% (0 B) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 62.80 MB 62.80 MB 0% (0 B) 👌
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 9.48 MB 9.48 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 106.15 MB 106.15 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.76 MB 10.76 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.26 MB 25.26 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 75.59 KB 75.59 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 167.23 MB 167.18 MB --.02% (-48.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 847.79 MB 847.79 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.61 MB 9.61 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 75.59 KB 75.59 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 23.10 MB 23.10 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 48.39 MB 48.39 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.33 MB 21.33 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 76.76 KB 76.76 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 171.34 MB 171.31 MB --.01% (-32.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 834.55 MB 834.55 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.27 MB 7.27 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 76.76 KB 76.76 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 24.71 MB 24.71 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 44.10 MB 44.10 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 80.27 MB 80.27 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.90 MB 9.90 MB 0% (0 B) 👌
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 64.68 MB 64.68 MB 0% (0 B) 👌
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 10.51 MB 10.51 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 100.11 MB 100.11 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.48 MB 11.48 MB 0% (0 B) 👌

@gleocadie gleocadie force-pushed the levi/fix-windows-declspec-vars branch from 0802540 to d844b01 Compare January 29, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working ci-build common

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrisonlevi @codecov-commenter @gleocadie