feat(crashtracking)!: emit crashing thread name in crash report for linux crashes #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gyuheon0h
changed the title
📚 Documentation Check Results📦
|
🔒 Cargo Deny Results📦
|
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 966d4f9 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
gyuheon0h
force-pushed
the
01-28-gyuheon0h_collect-thread-name
branch
2 times, most recently
from
29b2a99 to
4102352
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
========================================
Coverage 70.96% 70.97%
========================================
Files 421 421
Lines 68438 68580 +142
========================================
+ Hits 48567 48674 +107
- Misses 19871 19906 +35
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-01-28 19:52:00 Comparing candidate commit 966d4f9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
gyuheon0h
force-pushed
the
01-28-gyuheon0h_collect-thread-name
branch
from
4102352 to
d1e1f39
Compare
gyuheon0h
changed the title
gyuheon0h
changed the title
gyuheon0h
force-pushed
the
01-28-gyuheon0h_collect-thread-name
branch
from
9ca25d2 to
966d4f9
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
gleocadie
reviewed
Jan 29, 2026
Contributor
gleocadie
left a comment
gleocadie
left a comment
There was a problem hiding this comment.
Nice PR.
I have questions and we should also think about the message/log sent to the errors intake.
We may want to have same level of information here too.
Comment on lines
+166
to
+167
| #[cfg(target_os = "linux")] | ||
| emit_thread_name(pipe, ppid, crashing_tid)?; |
Contributor
There was a problem hiding this comment.
Why not letting the receiver gathering the thread name ? It might be simpler relying on the receiver no ?
We could imagine passing on the command line of the receiver the thread id of the crashing thread.
There is phase enrich_callstacks where the receiver enriches the frames with build id. We could have a enrich_thread which will be able to collect the thread name
| let mut buf = Vec::new(); | ||
|
|
||
| emit_thread_name(&mut buf, pid, tid).expect("thread name to emit"); | ||
| let out = str::from_utf8(&buf).expect("to be valid UTF8"); |
Contributor
There was a problem hiding this comment.
can you rename out to thread_name please
Comment on lines
+88
to
+92
| #[cfg(not(any(target_os = "linux", target_os = "macos")))] | ||
| fn current_tid() -> libc::pid_t { | ||
| 0 | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
~600 lines out of the 840 diff is from JSON schema update
This PR adds support to include the name of the crashing thread in the crash report. We cannot use
prctlor otherPthreadAPI in the collector, because those functionalities are not signal safe. However, we can send theproc/[pid]/task/[tid]to the receiver and do parsing there to retrieve the thread name.We add a
thread_namefield as an optional field to theErrorDataobject and update the schema and payload format RFC respectivelyWe also add an FFI api that allows consumers to set
thread_name.Motivation
It would be nice to know the name of the crashing thread in order to aid with debugging crashes.
Additional details
This PR only implements for Linux; MacOS is not supported yet.
How to test the change?
Run a crash and check the payload. Can also run
test_crash_tracking_thread_name.BREAKING CHANGE: