Build and package nginx ssi with RUM #288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…image The musl toolchain can now be built automatically from build_env/ as a bake dependency. This removes the need to pre-pull or maintain an external toolchain image. To use a pre-built image instead, set TOOLCHAIN_IMAGE. Also normalizes architecture naming (arm64 → aarch64) in Makefile for macOS compatibility. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…SI builds - Add inject-browser-sdk as submodule pinned to pawel-buildx-bake branch - Add docker bake targets for building inject-browser-sdk FFI artifacts - Add SSI targets (ssi-nginx, ssi-nginx-dev) that output OCI images with RUM enabled - Modify deps/CMakeLists.txt to support pre-built artifacts from docker bake - Update Dockerfile.nginx to copy pre-built artifacts instead of cloning repo - Fix compilation errors in src/rum/injection.cpp (pointer dereference, namespace) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Simplify docker-bake.hcl to only support standard nginx builds. Removes OPENRESTY_VERSIONS and INGRESS_NGINX_VERSIONS variables, their corresponding build targets, and group definitions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
pawelchcki
changed the title
- Remove WAF_OPTIONS variable and waf_to_dir helper function - Remove WAF from nginx target matrix, args, and output paths - Delete unused packaging/Dockerfile.ingress and packaging/Dockerfile.openresty Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add a PUSH variable that switches SSI target outputs between type=docker (default) and type=registry when PUSH=true, enabling images to be pushed to ghcr.io. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add Docker Bake targets and scripts for creating multi-arch OCI packages for the nginx SSI module using the datadog-packages tooling. New targets: - ssi-package-assemble[-dev]: Assembles nginx modules into package structure - ssi-package-create[-dev]: Creates per-arch OCI packages - ssi-package-merge[-dev]: Merges into multi-arch OCI index New scripts: - bin/generate-ssi-oci-package.sh: Full build (all nginx versions) - bin/generate-ssi-oci-package-dev.sh: Dev build (1.28.1 + 1.29.4 only) The packaging targets chain automatically via Docker Bake context dependencies, so running a single command builds nginx modules, assembles sources, and creates OCI packages. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use dockerfile-inline in bake to dynamically generate COPY statements from NGINX_VERSIONS variables, eliminating duplication between bake file and Dockerfiles. - Add ssi-nginx-modules[-dev] collector targets that combine all nginx build outputs into a single image - Simplify Dockerfile.ssi-sources to single COPY from collector - Remove Dockerfile.ssi-sources-dev (now unified) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Docker Buildx bake configuration for building nginx-datadog modules for SSI (Single Step Instrumentation) packages with RUM (Real User Monitoring) support.
What's new
Build targets
docker buildx bake ssi- Build all nginx modules with RUM for SSI packagesdocker buildx bake ssi-dev- Build subset (1.28.1, 1.29.4) for quick testingdocker buildx bake nginx-all- Build all nginx modules without RUMScope reduction
Dependencies
Test plan
docker buildx bake ssi-devto verify SSI builds work.soartifacts are generated for both architectures🤖 Generated with Claude Code