Skip to content

Conversation

@Pwhsky
Copy link
Collaborator

@Pwhsky Pwhsky commented Jan 23, 2025

Added graph augmentations for training MAGIK in the form of callable classes.

@BenjaminMidtvedt
Copy link
Collaborator

@Pwhsky Some of these augmentations are highly tracking-centric. Specifically flipping/translating/rotating nodes makes sense if the nodes contain XY positions. This is fine, but it should be clear from the naming, and I would suggest having all 2d tracking augmentations in a separate file.

I'd also homogenize the names. I'd suggest Node[Action], Edge[Action], e.g. NodeNoise, EdgeDropout.

Also, for a general noise augmentation, I'd expect more control over the distribution of the noise. I'd even have NodeNormalNoise, NodeUniformNoise, NodePoissonNoise etc.

In fact, looking at it deeper, I think all of the classes need to be able to be parameterized.

@Pwhsky
Copy link
Collaborator Author

Pwhsky commented Apr 5, 2025

Thank you for the feedback, I will implement what you suggested so it is both more general and customizable for what the user needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants