-
Notifications
You must be signed in to change notification settings - Fork 85
merge mxint_linear #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
merge mxint_linear #229
Conversation
|
@firemountain154B it seems like |
Plan to finish it today |
| def _trigger(self): | ||
| return self.valid.value == 1 and self.ready.value == 1 | ||
|
|
||
| # async def _driver_send(self, data) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just delete this?
| /* | ||
| Module : mxint_accumulator | ||
| Description : The accumulator for mxint. | ||
| When inputing different exponent, the mantissa will cast to the same bitwidth then accumulate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a lossy behaviour? If it is, it might worth to add a few more lines to explain its behaviour? I assume this is the module that aligns the exponent first?
| .out_data(mdata_out[i]) | ||
| ); | ||
| end | ||
| // for (genvar i = 0; i < BLOCK_SIZE; i++) begin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete dead code
| data_for_out_ready = buffer_data_for_out_ready; | ||
| end | ||
| end else begin | ||
| if (FIFO_DEPTH == 0) begin : register |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this FIFO depth here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a circular buffer? If it is, maybe add some comments at the top of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is a or_tree... this is confusing...
No description provided.