Skip to content

Conversation

@firemountain154B
Copy link
Contributor

No description provided.

@Aaron-Zhao123
Copy link
Collaborator

@firemountain154B it seems like mxint_cast.sv is failing the regression test, do you have any plans on fixing it so we can finish the PR?

@firemountain154B
Copy link
Contributor Author

@firemountain154B it seems like mxint_cast.sv is failing the regression test, do you have any plans on fixing it so we can finish the PR?

Plan to finish it today

def _trigger(self):
return self.valid.value == 1 and self.ready.value == 1

# async def _driver_send(self, data) -> None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just delete this?

/*
Module : mxint_accumulator
Description : The accumulator for mxint.
When inputing different exponent, the mantissa will cast to the same bitwidth then accumulate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a lossy behaviour? If it is, it might worth to add a few more lines to explain its behaviour? I assume this is the module that aligns the exponent first?

.out_data(mdata_out[i])
);
end
// for (genvar i = 0; i < BLOCK_SIZE; i++) begin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete dead code

data_for_out_ready = buffer_data_for_out_ready;
end
end else begin
if (FIFO_DEPTH == 0) begin : register
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this FIFO depth here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a circular buffer? If it is, maybe add some comments at the top of the file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a or_tree... this is confusing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants